amadan
spec: Astra whole-branch review brief for plans 3b
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 file changed,
+33
−0
docs/superpowers/specs/CODEX-REVIEW-BRIEF-PLANS-3B-CODE.md+33 −0
CI cancelled — superseded by a newer push — run details
CI log
=== gate === .amadan/test-gate.sh amadan: job cancelled — a newer push superseded it
diff --git a/docs/superpowers/specs/CODEX-REVIEW-BRIEF-PLANS-3B-CODE.md b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-PLANS-3B-CODE.md| new file mode 100644 |
| index 000000000..961cec610 |
| --- /dev/null |
| +++ b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-PLANS-3B-CODE.md |
| @@ -0,0 +1,33 @@ |
| +# Whole-branch code review brief: Plans 3b (never-sleep and schedule refusals) |
| + |
| +You are a senior Go reviewer on the carlos platform. Review branch |
| +`plans-3b-never-sleep`, range `bcae2a72b005abe86b99edc1a51d49b6d4f6bbe1..HEAD` (`git diff bcae2a72b005abe86b99edc1a51d49b6d4f6bbe1..HEAD`; docs under |
| +docs/superpowers/ are requirements). Read-only: do not modify the working |
| +tree, index, HEAD or branches. You may run `go test` with GOFLAGS=-buildvcs=false. |
| + |
| +Requirements: the spec docs/superpowers/specs/2026-10-20-plans-caps-packs-design.md |
| +§5.2 (section 3 decisions are not to be argued with); the plan |
| +docs/superpowers/plans/2026-10-23-plans-3b-never-sleep.md, including its |
| +"Own boxes" section (always-on allowed when the app is placed on the |
| +account's own fleet); the executor's `Ruling:` lines in |
| +.superpowers/sdd/2026-10-23-plans-3b-never-sleep/progress.md. |
| + |
| +Grade by effect. Check deliberately (Review Focus): plans off changes |
| +nothing; a re-ship of an already-shipped daemon release is refused under a |
| +plan on shared boxes; cron lines that fire faster than the minimum are |
| +refused and ones that meet it are allowed (schedule.ShortestInterval, its |
| +62-day window, irregular crons, day-of-month/day-of-week combinations); |
| +enabling sidecars without a hibernate field leaves an existing setting. |
| + |
| +Also look hard at: every member path that can make an app never sleep (ship, |
| +deploy, promote of an already-shipped daemon release, sidecar create vs |
| +enable, operator-only paths excluded) and whether any bypasses the check; |
| +how onOwnBoxes decides (stored placement, route fallback, registry open |
| +failures, a placement naming a fleet the account does not own); schedule |
| +paths other than the console door; error handling; the census card's |
| +honesty. |
| + |
| +Do not review the wording (approved copy in plancaps_copy.go). |
| + |
| +Output: findings most severe first (Critical / Important / Minor, file:line, |
| +failure scenario, fix); then "Declined to judge"; then a verdict. |