carlos / platform Public

host: schedule_wiring.go — two words in the proxy-cache comment

'TCP-over-unix' is not a thing; a unix socket connection is a connection.
Paul Campbell pushed by paul@keymail.dev 423207a5e12b94579e79afe8a1977c262e1e0a7f parent 84a55c3
1 file changed, +5 −5
  • internal/host/schedule_wiring.go +5 −5
diff --git a/internal/host/schedule_wiring.go b/internal/host/schedule_wiring.go
index ce773bc03..0968e0def 100644
--- a/internal/host/schedule_wiring.go
+++ b/internal/host/schedule_wiring.go
@@ -215,9 +215,9 @@ type activatorDeliverer struct {
// proxies caches one unix proxy — and therefore one http.Transport, and
// therefore one connection pool — per socket path. A fresh Transport per
- // delivery meant a fresh TCP-over-unix connection for every tick and a
- // pool that was thrown away unread; a schedule that fires every minute
- // paid a dial (and the runtime a goroutine pair) each time for nothing.
+ // delivery meant a fresh connection for every tick and a pool thrown
+ // away unread; a schedule that fires every minute paid a dial (and the
+ // runtime a reader goroutine) each time for nothing.
// Keyed by socket path rather than host because the path is what the
// Transport actually dials: a route re-pointed at a new socket gets a new
// entry rather than a pool aimed at the old file.
@@ -282,8 +282,8 @@ func (d *activatorDeliverer) Deliver(ctx context.Context, rt registry.Route, req
if err != nil {
// Anything that did not come back as an HTTP status — a refused
// wake, a socket that would not dial, a deadline — retires this
- // socket's pool. The next tick dials fresh; a route that has gone
- // away leaves nothing behind.
+ // socket's pool. The next tick dials fresh, and a route that has
+ // gone away leaves nothing behind.
d.dropProxy(rt.Socket)
}
if err != nil && ctx.Err() == nil {