leasetest: the versioned bucket model and the VersionedStore contract (claim Plan 2 Task 2)
Co-Authored-By: Codex <noreply@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 files changed,
+600
−0
internal/lease/leasetest/bucket.go+340 −0internal/lease/leasetest/bucket_test.go+15 −0internal/lease/leasetest/contract.go+245 −0
diff --git a/internal/lease/leasetest/bucket.go b/internal/lease/leasetest/bucket.go| new file mode 100644 |
| index 000000000..fe13f4d98 |
| --- /dev/null |
| +++ b/internal/lease/leasetest/bucket.go |
| @@ -0,0 +1,340 @@ |
| +// Package leasetest holds test doubles for internal/lease. VersionedBucket |
| +// is the reference model of a versioned S3 bucket that every plan of the |
| +// host lifecycle claim tests against (spec §13). |
| +package leasetest |
| + |
| +import ( |
| + "bytes" |
| + "context" |
| + "crypto/md5" |
| + "encoding/hex" |
| + "fmt" |
| + "io" |
| + "sort" |
| + "strings" |
| + "sync" |
| + "time" |
| + |
| + "github.com/carlosframework/platform/internal/lease" |
| +) |
| + |
| +type version struct { |
| + id string |
| + body []byte |
| + etag string |
| + deleteMarker bool |
| + modified time.Time |
| +} |
| + |
| +// VersionedBucket is an in-memory, versioned, multi-bucket S3 model. |
| +type VersionedBucket struct { |
| + mu sync.Mutex |
| + buckets map[string]map[string][]version // bucket -> key -> versions, newest first |
| + next int |
| + clock time.Time |
| + |
| + PageSize int // listing page size; default 1000 |
| + FailListAfterPages int // fail a listing once this many pages have been served; 0 never |
| + FailOn func(op, key string) error // op: list|get|copy|delete|put |
| +} |
| + |
| +func NewVersionedBucket() *VersionedBucket { |
| + return &VersionedBucket{buckets: map[string]map[string][]version{}, PageSize: 1000, |
| + clock: time.Date(2026, 10, 5, 0, 0, 0, 0, time.UTC)} |
| +} |
| + |
| +func md5hex(b []byte) string { s := md5.Sum(b); return hex.EncodeToString(s[:]) } |
| + |
| +func (f *VersionedBucket) AddBucket(name string) { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + if f.buckets[name] == nil { |
| + f.buckets[name] = map[string][]version{} |
| + } |
| +} |
| + |
| +// --- locked helpers: callers hold f.mu --- |
| + |
| +func (f *VersionedBucket) fail(op, key string) error { |
| + if f.FailOn != nil { |
| + return f.FailOn(op, key) |
| + } |
| + return nil |
| +} |
| + |
| +func (f *VersionedBucket) known(bucket string) error { |
| + if _, ok := f.buckets[bucket]; !ok { |
| + return fmt.Errorf("leasetest: no bucket %q", bucket) |
| + } |
| + return nil |
| +} |
| + |
| +func (f *VersionedBucket) push(bucket, key string, v version) string { |
| + f.next++ |
| + f.clock = f.clock.Add(time.Second) |
| + v.id, v.modified = fmt.Sprintf("v%06d", f.next), f.clock |
| + f.buckets[bucket][key] = append([]version{v}, f.buckets[bucket][key]...) |
| + return v.id |
| +} |
| + |
| +func (f *VersionedBucket) hasCurrent(bucket, key string) bool { |
| + vs := f.buckets[bucket][key] |
| + return len(vs) > 0 && !vs[0].deleteMarker |
| +} |
| + |
| +func (f *VersionedBucket) find(bucket, key, id string) (version, bool) { |
| + for _, v := range f.buckets[bucket][key] { |
| + if v.id == id { |
| + return v, true |
| + } |
| + } |
| + return version{}, false |
| +} |
| + |
| +// listAll is the whole ordered listing under prefix (key order, newest |
| +// first within a key). |
| +func (f *VersionedBucket) listAll(bucket, prefix string) []lease.ObjectVersion { |
| + o := f.buckets[bucket] |
| + keys := make([]string, 0, len(o)) |
| + for k := range o { |
| + if strings.HasPrefix(k, prefix) { |
| + keys = append(keys, k) |
| + } |
| + } |
| + sort.Strings(keys) |
| + var all []lease.ObjectVersion |
| + for _, k := range keys { |
| + for i, v := range o[k] { |
| + ov := lease.ObjectVersion{Key: k, VersionID: v.id, IsLatest: i == 0, DeleteMarker: v.deleteMarker, LastModified: v.modified} |
| + if !v.deleteMarker { |
| + ov.ETag, ov.Size = v.etag, int64(len(v.body)) |
| + } |
| + all = append(all, ov) |
| + } |
| + } |
| + return all |
| +} |
| + |
| +// pageOf returns page number page (0-based) of all, whether more follow, |
| +// and the failure FailListAfterPages injects. |
| +func (f *VersionedBucket) pageOf(all []lease.ObjectVersion, page int) ([]lease.ObjectVersion, bool, error) { |
| + if f.FailListAfterPages > 0 && page >= f.FailListAfterPages { |
| + return nil, false, fmt.Errorf("leasetest: injected listing failure on page %d", page+1) |
| + } |
| + size := f.PageSize |
| + if size <= 0 { |
| + size = 1000 |
| + } |
| + start := page * size |
| + if start > len(all) { |
| + start = len(all) |
| + } |
| + end := start + size |
| + if end >= len(all) { |
| + return all[start:], false, nil |
| + } |
| + return all[start:end], true, nil |
| +} |
| + |
| +// --- exported helpers for tests --- |
| + |
| +func (f *VersionedBucket) Put(bucket, key string, body []byte) string { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + return f.push(bucket, key, version{body: append([]byte(nil), body...), etag: md5hex(body)}) |
| +} |
| + |
| +func (f *VersionedBucket) PutMultipart(bucket, key string, body []byte) string { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + return f.push(bucket, key, version{body: append([]byte(nil), body...), etag: md5hex(body) + "-2"}) |
| +} |
| + |
| +func (f *VersionedBucket) BareDelete(bucket, key string) string { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + return f.push(bucket, key, version{deleteMarker: true}) |
| +} |
| + |
| +func (f *VersionedBucket) LatestID(bucket, key string) string { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + if vs := f.buckets[bucket][key]; len(vs) > 0 { |
| + return vs[0].id |
| + } |
| + return "" |
| +} |
| + |
| +func (f *VersionedBucket) Current(bucket, key string) ([]byte, bool) { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + vs := f.buckets[bucket][key] |
| + if len(vs) == 0 || vs[0].deleteMarker { |
| + return nil, false |
| + } |
| + return vs[0].body, true |
| +} |
| + |
| +// Snapshot renders the whole state, for before/after comparison. |
| +func (f *VersionedBucket) Snapshot() string { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + var b strings.Builder |
| + names := make([]string, 0, len(f.buckets)) |
| + for n := range f.buckets { |
| + names = append(names, n) |
| + } |
| + sort.Strings(names) |
| + for _, n := range names { |
| + for _, v := range f.listAll(n, "") { |
| + fmt.Fprintf(&b, "%s/%s@%s:%v:%s\n", n, v.Key, v.VersionID, v.DeleteMarker, v.ETag) |
| + } |
| + } |
| + return b.String() |
| +} |
| + |
| +// --- lease.VersionedStore --- |
| + |
| +func (f *VersionedBucket) ListVersions(ctx context.Context, bucket, prefix string) ([]lease.ObjectVersion, error) { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + if err := f.known(bucket); err != nil { |
| + return nil, err |
| + } |
| + if err := f.fail("list", prefix); err != nil { |
| + return nil, err |
| + } |
| + all := f.listAll(bucket, prefix) |
| + var out []lease.ObjectVersion |
| + for page := 0; ; page++ { |
| + vs, more, err := f.pageOf(all, page) |
| + if err != nil { |
| + return nil, err |
| + } |
| + out = append(out, vs...) |
| + if !more { |
| + return out, nil |
| + } |
| + } |
| +} |
| + |
| +func (f *VersionedBucket) read(bucket, key, versionID string) ([]byte, error) { |
| + if versionID == "" { |
| + return nil, lease.ErrNoVersionID |
| + } |
| + if err := f.known(bucket); err != nil { |
| + return nil, err |
| + } |
| + if err := f.fail("get", key); err != nil { |
| + return nil, err |
| + } |
| + v, ok := f.find(bucket, key, versionID) |
| + if !ok { |
| + return nil, lease.ErrMirrorNotFound |
| + } |
| + if v.deleteMarker { |
| + return nil, lease.ErrIsDeleteMarker |
| + } |
| + return append([]byte(nil), v.body...), nil |
| +} |
| + |
| +func (f *VersionedBucket) GetVersion(ctx context.Context, bucket, key, versionID string) ([]byte, error) { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + return f.read(bucket, key, versionID) |
| +} |
| + |
| +func (f *VersionedBucket) OpenVersion(ctx context.Context, bucket, key, versionID string) (io.ReadCloser, error) { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + b, err := f.read(bucket, key, versionID) |
| + if err != nil { |
| + return nil, err |
| + } |
| + return io.NopCloser(bytes.NewReader(b)), nil |
| +} |
| + |
| +func (f *VersionedBucket) copyLocked(srcBucket, srcKey, srcVersionID, dstBucket, dstKey string, createOnly bool) (string, string, error) { |
| + if srcVersionID == "" { |
| + return "", "", lease.ErrNoVersionID |
| + } |
| + if err := f.known(srcBucket); err != nil { |
| + return "", "", err |
| + } |
| + if err := f.known(dstBucket); err != nil { |
| + return "", "", err |
| + } |
| + if err := f.fail("copy", srcKey); err != nil { |
| + return "", "", err |
| + } |
| + v, ok := f.find(srcBucket, srcKey, srcVersionID) |
| + if !ok { |
| + return "", "", lease.ErrMirrorNotFound |
| + } |
| + if v.deleteMarker { |
| + return "", "", lease.ErrIsDeleteMarker |
| + } |
| + if createOnly && f.hasCurrent(dstBucket, dstKey) { |
| + return "", "", lease.ErrDestinationExists |
| + } |
| + etag := md5hex(v.body) // a copy is single-part (§13 row 9) |
| + return f.push(dstBucket, dstKey, version{body: append([]byte(nil), v.body...), etag: etag}), etag, nil |
| +} |
| + |
| +func (f *VersionedBucket) CopyVersion(ctx context.Context, srcBucket, srcKey, srcVersionID, dstBucket, dstKey string, createOnly bool) (string, string, error) { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + return f.copyLocked(srcBucket, srcKey, srcVersionID, dstBucket, dstKey, createOnly) |
| +} |
| + |
| +func (f *VersionedBucket) deleteLocked(bucket, key, versionID string) error { |
| + if versionID == "" { |
| + return lease.ErrNoVersionID |
| + } |
| + if err := f.known(bucket); err != nil { |
| + return err |
| + } |
| + if err := f.fail("delete", key); err != nil { |
| + return err |
| + } |
| + vs := f.buckets[bucket][key] |
| + for i, v := range vs { |
| + if v.id == versionID { |
| + rest := append(vs[:i:i], vs[i+1:]...) |
| + if len(rest) == 0 { |
| + delete(f.buckets[bucket], key) |
| + } else { |
| + f.buckets[bucket][key] = rest |
| + } |
| + return nil |
| + } |
| + } |
| + return nil |
| +} |
| + |
| +func (f *VersionedBucket) DeleteVersion(ctx context.Context, bucket, key, versionID string) error { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + return f.deleteLocked(bucket, key, versionID) |
| +} |
| + |
| +func (f *VersionedBucket) putIfAbsentLocked(bucket, key string, body []byte) (string, error) { |
| + if err := f.known(bucket); err != nil { |
| + return "", err |
| + } |
| + if err := f.fail("put", key); err != nil { |
| + return "", err |
| + } |
| + if f.hasCurrent(bucket, key) { |
| + return "", lease.ErrExists |
| + } |
| + return f.push(bucket, key, version{body: append([]byte(nil), body...), etag: md5hex(body)}), nil |
| +} |
| + |
| +func (f *VersionedBucket) PutIfAbsent(ctx context.Context, bucket, key string, body []byte) (string, error) { |
| + f.mu.Lock() |
| + defer f.mu.Unlock() |
| + return f.putIfAbsentLocked(bucket, key, body) |
| +} |
| + |
| +var _ lease.VersionedStore = (*VersionedBucket)(nil) |
diff --git a/internal/lease/leasetest/bucket_test.go b/internal/lease/leasetest/bucket_test.go| new file mode 100644 |
| index 000000000..d711a6f49 |
| --- /dev/null |
| +++ b/internal/lease/leasetest/bucket_test.go |
| @@ -0,0 +1,15 @@ |
| +package leasetest |
| + |
| +import ( |
| + "testing" |
| + |
| + "github.com/carlosframework/platform/internal/lease" |
| +) |
| + |
| +func TestVersionedBucketContract(t *testing.T) { |
| + RunVersionedStoreContract(t, func(t *testing.T) (lease.VersionedStore, *VersionedBucket, string, func() int) { |
| + m := NewVersionedBucket() |
| + m.AddBucket("data") |
| + return m, m, "data", nil |
| + }) |
| +} |
diff --git a/internal/lease/leasetest/contract.go b/internal/lease/leasetest/contract.go| new file mode 100644 |
| index 000000000..26a8847ca |
| --- /dev/null |
| +++ b/internal/lease/leasetest/contract.go |
| @@ -0,0 +1,245 @@ |
| +package leasetest |
| + |
| +import ( |
| + "context" |
| + "errors" |
| + "fmt" |
| + "io" |
| + "strings" |
| + "testing" |
| + |
| + "github.com/carlosframework/platform/internal/lease" |
| +) |
| + |
| +// Maker builds a store under test, the model backing it, the bucket name, |
| +// and (for wire stores) a request counter. |
| +type Maker func(t *testing.T) (st lease.VersionedStore, m *VersionedBucket, bucket string, served func() int) |
| + |
| +// RunVersionedStoreContract is the behaviour every lease.VersionedStore |
| +// must have (spec §13, as covered by Plan 2). |
| +func RunVersionedStoreContract(t *testing.T, mk Maker) { |
| + ctx := context.Background() |
| + |
| + t.Run("listing: key order, latest first, markers included, prefix bounded", func(t *testing.T) { |
| + st, m, b, _ := mk(t) |
| + m.Put(b, "p/a", []byte("one")) |
| + m.Put(b, "p/a", []byte("two")) |
| + m.BareDelete(b, "p/a") |
| + m.Put(b, "p/b", []byte("x")) |
| + m.Put(b, "q/c", []byte("other prefix")) |
| + vs, err := st.ListVersions(ctx, b, "p/") |
| + if err != nil { |
| + t.Fatal(err) |
| + } |
| + if len(vs) != 4 || vs[0].Key != "p/a" || !vs[0].IsLatest || !vs[0].DeleteMarker || vs[3].Key != "p/b" || !vs[3].IsLatest { |
| + t.Fatalf("listing = %+v", vs) |
| + } |
| + for _, v := range vs[1:3] { |
| + if v.Key != "p/a" || v.IsLatest || v.DeleteMarker || v.VersionID == "" { |
| + t.Fatalf("non-latest entries = %+v", vs[1:3]) |
| + } |
| + } |
| + }) |
| + |
| + t.Run("listing spans pages, including many versions of one key", func(t *testing.T) { |
| + st, m, b, _ := mk(t) |
| + m.PageSize = 3 |
| + for i := 0; i < 5; i++ { |
| + m.Put(b, "p/same", []byte{byte(i)}) |
| + } |
| + for i := 0; i < 4; i++ { |
| + m.Put(b, fmt.Sprintf("p/k%02d", i), []byte{byte(i)}) |
| + } |
| + vs, err := st.ListVersions(ctx, b, "p/") |
| + if err != nil || len(vs) != 9 { |
| + t.Fatalf("paged listing = %d, %v; want 9", len(vs), err) |
| + } |
| + seen := map[string]bool{} |
| + for _, v := range vs { |
| + if seen[v.Key+"@"+v.VersionID] { |
| + t.Fatalf("duplicate %s@%s", v.Key, v.VersionID) |
| + } |
| + seen[v.Key+"@"+v.VersionID] = true |
| + } |
| + }) |
| + |
| + t.Run("listing fails whole on a page error", func(t *testing.T) { |
| + st, m, b, _ := mk(t) |
| + m.PageSize = 2 |
| + for i := 0; i < 6; i++ { |
| + m.Put(b, fmt.Sprintf("p/k%d", i), []byte{byte(i)}) |
| + } |
| + m.FailListAfterPages = 2 |
| + if vs, err := st.ListVersions(ctx, b, "p/"); err == nil { |
| + t.Fatalf("got %d entries and no error", len(vs)) |
| + } |
| + }) |
| + |
| + t.Run("read and stream by exact version; markers and missing", func(t *testing.T) { |
| + st, m, b, _ := mk(t) |
| + k := "dir/a b+c%?d" |
| + v1 := m.Put(b, k, []byte("old")) |
| + m.Put(b, k, []byte("new")) |
| + if body, err := st.GetVersion(ctx, b, k, v1); err != nil || string(body) != "old" { |
| + t.Fatalf("GetVersion = %q, %v", body, err) |
| + } |
| + rc, err := st.OpenVersion(ctx, b, k, v1) |
| + if err != nil { |
| + t.Fatal(err) |
| + } |
| + body, _ := io.ReadAll(rc) |
| + rc.Close() |
| + if string(body) != "old" { |
| + t.Fatalf("OpenVersion = %q", body) |
| + } |
| + mk1 := m.BareDelete(b, k) |
| + if _, err := st.GetVersion(ctx, b, k, mk1); !errors.Is(err, lease.ErrIsDeleteMarker) { |
| + t.Fatalf("GetVersion(marker) = %v, want ErrIsDeleteMarker", err) |
| + } |
| + if _, err := st.GetVersion(ctx, b, k, "v999999"); !errors.Is(err, lease.ErrMirrorNotFound) { |
| + t.Fatalf("GetVersion(missing) = %v, want ErrMirrorNotFound", err) |
| + } |
| + // A version hidden behind a marker is still readable by id. |
| + if body, err := st.GetVersion(ctx, b, k, v1); err != nil || string(body) != "old" { |
| + t.Fatalf("GetVersion behind a marker = %q, %v", body, err) |
| + } |
| + }) |
| + |
| + t.Run("copy by exact version; create-only; markers", func(t *testing.T) { |
| + st, m, b, _ := mk(t) |
| + k := "src/a b+c%?d" |
| + v1 := m.Put(b, k, []byte("old")) |
| + m.Put(b, k, []byte("new")) |
| + dv, etag, err := st.CopyVersion(ctx, b, k, v1, b, "dst/x", true) |
| + if err != nil || dv == "" || etag == "" || strings.Contains(etag, "-") { |
| + t.Fatalf("CopyVersion = %q %q %v", dv, etag, err) |
| + } |
| + if cur, ok := m.Current(b, "dst/x"); !ok || string(cur) != "old" { |
| + t.Fatalf("copied %q", cur) |
| + } |
| + if _, _, err := st.CopyVersion(ctx, b, k, v1, b, "dst/x", true); !errors.Is(err, lease.ErrDestinationExists) { |
| + t.Fatalf("create-only copy onto existing = %v", err) |
| + } |
| + m.BareDelete(b, "dst/x") |
| + if _, _, err := st.CopyVersion(ctx, b, k, v1, b, "dst/x", true); err != nil { |
| + t.Fatalf("create-only copy over a delete marker = %v", err) |
| + } |
| + mid := m.BareDelete(b, k) |
| + if _, _, err := st.CopyVersion(ctx, b, k, mid, b, "dst/y", false); !errors.Is(err, lease.ErrIsDeleteMarker) { |
| + t.Fatalf("copy of a marker = %v, want ErrIsDeleteMarker", err) |
| + } |
| + mpID := m.PutMultipart(b, "src/mp", []byte("payload")) |
| + if _, etag, err := st.CopyVersion(ctx, b, "src/mp", mpID, b, "dst/mp", false); err != nil || strings.Contains(etag, "-") { |
| + t.Fatalf("multipart copy etag = %q, %v; want single-part", etag, err) |
| + } |
| + }) |
| + |
| + t.Run("delete by version: exact, idempotent, never bare", func(t *testing.T) { |
| + st, m, b, served := mk(t) |
| + v1 := m.Put(b, "k", []byte("one")) |
| + v2 := m.Put(b, "k", []byte("two")) |
| + if err := st.DeleteVersion(ctx, b, "k", v2); err != nil { |
| + t.Fatal(err) |
| + } |
| + if cur, ok := m.Current(b, "k"); !ok || string(cur) != "one" { |
| + t.Fatalf("after deleting the current version: %q %v; want the older one current", cur, ok) |
| + } |
| + if err := st.DeleteVersion(ctx, b, "k", v2); err != nil { |
| + t.Fatalf("re-delete = %v", err) |
| + } |
| + if err := st.DeleteVersion(ctx, b, "never", "v000001"); err != nil { |
| + t.Fatalf("delete on a missing key = %v", err) |
| + } |
| + before, reqs := m.Snapshot(), 0 |
| + if served != nil { |
| + reqs = served() |
| + } |
| + if err := st.DeleteVersion(ctx, b, "k", ""); !errors.Is(err, lease.ErrNoVersionID) { |
| + t.Fatalf("empty version id = %v, want ErrNoVersionID", err) |
| + } |
| + if _, err := st.GetVersion(ctx, b, "k", ""); !errors.Is(err, lease.ErrNoVersionID) { |
| + t.Fatalf("GetVersion(\"\") = %v, want ErrNoVersionID", err) |
| + } |
| + if _, err := st.OpenVersion(ctx, b, "k", ""); !errors.Is(err, lease.ErrNoVersionID) { |
| + t.Fatalf("OpenVersion(\"\") = %v, want ErrNoVersionID", err) |
| + } |
| + if _, _, err := st.CopyVersion(ctx, b, "k", "", b, "k2", false); !errors.Is(err, lease.ErrNoVersionID) { |
| + t.Fatalf("CopyVersion(\"\") = %v, want ErrNoVersionID", err) |
| + } |
| + if m.Snapshot() != before { |
| + t.Fatal("state changed on an empty-version delete") |
| + } |
| + if served != nil && served() != reqs { |
| + t.Fatal("a request was sent for an empty version id") |
| + } |
| + _ = v1 |
| + }) |
| + |
| + t.Run("delete a noncurrent version keeps the current one", func(t *testing.T) { |
| + st, m, b, _ := mk(t) |
| + v1 := m.Put(b, "k", []byte("one")) |
| + v2 := m.Put(b, "k", []byte("two")) |
| + if err := st.DeleteVersion(ctx, b, "k", v1); err != nil { |
| + t.Fatal(err) |
| + } |
| + if cur, ok := m.Current(b, "k"); !ok || string(cur) != "two" || m.LatestID(b, "k") != v2 { |
| + t.Fatalf("current after a noncurrent delete = %q %v %s", cur, ok, m.LatestID(b, "k")) |
| + } |
| + if _, err := st.GetVersion(ctx, b, "k", v1); !errors.Is(err, lease.ErrMirrorNotFound) { |
| + t.Fatalf("deleted version still readable: %v", err) |
| + } |
| + }) |
| + |
| + t.Run("a missing bucket is an error, never absence", func(t *testing.T) { |
| + st, _, _, _ := mk(t) |
| + if err := st.DeleteVersion(ctx, "nobucket", "k", "v000001"); err == nil { |
| + t.Error("delete in a missing bucket succeeded") |
| + } |
| + if _, err := st.GetVersion(ctx, "nobucket", "k", "v000001"); err == nil || errors.Is(err, lease.ErrMirrorNotFound) { |
| + t.Errorf("get in a missing bucket = %v", err) |
| + } |
| + if _, err := st.ListVersions(ctx, "nobucket", ""); err == nil { |
| + t.Error("list of a missing bucket succeeded") |
| + } |
| + }) |
| + |
| + t.Run("put if absent", func(t *testing.T) { |
| + st, m, b, _ := mk(t) |
| + if v, err := st.PutIfAbsent(ctx, b, "m/closed.json", []byte("{}")); err != nil || v == "" { |
| + t.Fatalf("first = %q %v", v, err) |
| + } |
| + if _, err := st.PutIfAbsent(ctx, b, "m/closed.json", []byte("{}")); !errors.Is(err, lease.ErrExists) { |
| + t.Fatalf("second = %v, want ErrExists", err) |
| + } |
| + m.BareDelete(b, "m/closed.json") |
| + if _, err := st.PutIfAbsent(ctx, b, "m/closed.json", []byte("{}")); err != nil { |
| + t.Fatalf("over a marker = %v", err) |
| + } |
| + }) |
| + |
| + t.Run("injected failures surface as errors from every operation", func(t *testing.T) { |
| + st, m, b, _ := mk(t) |
| + v := m.Put(b, "k", []byte("x")) |
| + boom := errors.New("boom") |
| + m.FailOn = func(op, key string) error { return boom } |
| + if _, err := st.ListVersions(ctx, b, ""); err == nil { |
| + t.Error("list: no error") |
| + } |
| + if _, err := st.GetVersion(ctx, b, "k", v); err == nil || errors.Is(err, lease.ErrMirrorNotFound) { |
| + t.Errorf("get: %v", err) |
| + } |
| + if _, _, err := st.CopyVersion(ctx, b, "k", v, b, "k2", false); err == nil || errors.Is(err, lease.ErrMirrorNotFound) { |
| + t.Errorf("copy: %v", err) |
| + } |
| + if err := st.DeleteVersion(ctx, b, "k", v); err == nil { |
| + t.Error("delete: no error") |
| + } |
| + if _, err := st.PutIfAbsent(ctx, b, "new", []byte("x")); err == nil { |
| + t.Error("put: no error") |
| + } |
| + m.FailOn = nil |
| + if _, ok := m.Current(b, "k"); !ok { |
| + t.Fatal("a failed delete removed data") |
| + } |
| + }) |
| +} |