amadan
e2e: TestE2EDeployThroughConsole fails on main with a poll that carries no cache-bust param (timing-dependent) Issue open
Migrated from github.com/carlosframework/platform issue #312, opened 2026-08-26. GitHub issues are closed for this repo; see AGENTS.md, "Work is tracked on amadan, not GitHub".
Still outstanding: A second, non-watch requester races the deploy watch's cache-busted polls in TestE2EDeployThroughConsole.
---
Seen 2026-08-27 ~00:10 local while gating PR #311; reproduced on main 845a850 in a clean worktree.
--- FAIL: TestE2EDeployThroughConsole (2.02s)
deploy_e2e_test.go:409: poll without the cache-bust param: [carlos-deploy-probe=1 carlos-deploy-probe=2]The fake edge recorded THREE requests: probe 1, one with an empty query, probe 2. deploy.go's watch is the only origin GET in the verb and always carries ?carlos-deploy-probe=<n> (deploy.go:1210), so the empty-query request comes from something else in the process reaching the same host through the test's dial seam, racing the watch. Timing-sensitive: 3/3 failures with go test . -run TestE2EDeployThroughConsole, then a pass with -v on the same tree. Earlier today the full gate passed this test repeatedly (at 5e9b918, cab3b09), so whatever races it is marginal.
Worth finding the second requester (log method/path/UA in the fake handler when the query is empty) rather than loosening the assertion — the assertion is the point of the test (the watch must never pass on a cached answer).