amadan
internal/activator: TestActivatorWakeFailuresReleaseLeaseOnce is flaky under the full suite Issue open
Migrated from github.com/carlosframework/platform issue #228, opened 2026-08-18. GitHub issues are closed for this repo; see AGENTS.md, "Work is tracked on amadan, not GitHub".
Still outstanding: TestActivatorWakeFailuresReleaseLeaseOnce is flaky under the full suite; cross-package contention still unexplained.
---
Found while running the gate repeatedly on #227; not caused by that branch.
What happens
TestActivatorWakeFailuresReleaseLeaseOnce fails in roughly two of five go test ./... runs. Under isolation it does not fail at all:
- 60 isolated runs under contention — all clean
- 2 whole-package runs — clean
- ~2 in 5 full-suite runs — fail
Why it is not #227
go list -deps -test ./internal/activator contains neither internal/console nor internal/svcrole, so nothing that branch changed is linked into that test binary. The pattern — clean alone, flaky only alongside the rest of the suite — points at contention with other packages rather than at logic in the test.
Where to look
internal/lease is the likely home: the test's subject is lease release on wake failure, and "releases the lease exactly once" is the kind of assertion that goes intermittent when a timeout is tuned for an unloaded machine.
Why it is worth fixing rather than tolerating
A test that fails two runs in five trains people to re-run the suite until it is green, which is how a real regression gets waved through. It also makes any CI failure on an unrelated branch ambiguous.