amadan
windows go vet fails on test files across many packages (CI doesn't vet cross-OS) open
GOOS=windows go vet ./... fails on main (3b69c2bd) in test files across at least seven packages:
- internal/release/versions_test.go: syscall.Umask
- internal/hostfloor/plan9atest.go: syscall.Stat_t
- internal/hostguard/plan14rebindtest.go: fenceFixture
- internal/appconfig/syncexec_test.go: unix.Mkfifo
- internal/hostbox/plan9fix2minors_test.go: plan9D1Probe
- internal/activator/activator_test.go: unix.Mkfifo
- and more
CI's cross-compile gate builds the binaries for darwin and windows but doesn't vet test files, so this has drifted unseen. darwin vet of internal/host was fixed in 04819f9 (claimunitinputstest.go).
Proposed fix: build tags (//go:build linux or unix) on the linux-only test files, then add GOOS=windows go vet ./... and GOOS=darwin go vet ./... to the CI gate so they stay fixed. Test-only; release binaries are unaffected.