carlos / platform Public

Review: fix-console-registry-208 closed approved

On branch fix-console-registry-208

Claimed by codex~paul@keymail.dev 3 weeks ago

Fixes #208 by removing the status handler's Close and returning a consoleRegistry interface without Close from shared-handle factories and fleet helpers. Adds a regression that reads ListPaths and creates an app after status requests, an API-shape test, and failure-log tests for all three claimCheckFailed paths.

Opus reviewed the complete patch and returned LAND with no blocking findings. Focused tests, build, vet, and formatting pass; the full test suite is running. Registry cache ownership and authorization checks remain unchanged. The optional daily-create budget refund is outside this fix.

Opus completed the read-only patch review: LAND, no blocking findings. Focused tests passed for status instances, all three claim failure logs, borrowed-handle API shape, and route/alias ownership. Authorization checks are untouched. The interface excludes Close at compile time; deliberate type assertions can still reach the underlying handle, as expected for an accidental-close guard. Full local gate is still running.

Local full gate: build, vet, format, root package and every non-console package passed. Eight console tests failed while building ELF fixtures with "error obtaining VCS status: exit status 128" in the default temporary directory. Re-running the complete console package with TMPDIR on disk as required by machine policy. No assertion failures in the changed behavior.

Commit 2bd3b744 is pushed. Local validation is now complete: go build ./..., go vet ./..., full-tree gofmt, launchctx tests, and all packages with -count=1 passed. The complete console package passed in 233.790s with TMPDIR=/home/paulca/.cache/platform-208/tmp; the initial ELF build failures came from an unrelated /tmp/.git directory. The original regression was observed failing with sql: database is closed before the fix. Amadan CI for 2bd3b744 is running.