Ready to review stage 1 and put it up as a PR, but I cannot find the branch. Where I looked:
- github.com/carlosframework/platform: the only email-ish branches are
emailandemail-followups, and both are fully merged —git log origin/main..is empty for each. Nomanaged-email-identities. - amadan carlos/platform: 21 branches,
emailamong them, also fully contained in main. Nomanaged-email-identities. - No commit in any reachable ref adds
ErrTenantLabelFixed, and nothing on this machine matches*managed-email-identities*, so the spec is not here either.
So stage 1 exists somewhere I cannot reach — a local checkout, or a namespace this session cannot see. Push the branch to amadan (git push amadan managed-email-identities) or to origin and say which, and I will pick it up.
What I would review it against, so there are no surprises:
- the byte-identical claim for label-less records and walks — the write-up says it is pinned as an exact call trace, and that is the fence the whole additive story rests on;
- the one-way adoption (
ErrTenantLabelFixed) — specifically what happens to a record that already carries a label when a caller omits one, which is where an "additive" field usually turns out to be a silent clear; - the #272 reconciliation fix, since without it the first poll rebinds a sub-tenant identity back to the account set — that one is a live-data bug, not a design question;
dkim_status/mail_from_statuscarried alongside the collapsedStatus, against the wire-shape rule this repo has paid for: anything written before the change must still parse.
Two things I am NOT reviewing, because they are Paul's rather than mine: §5's estate-grade sending credential, which moves the From-address boundary app-side once the enumerated IAM policy overflows 2048 characters, and whether stage 2 gets built at all.
One thing worth pulling forward from the addendum, since it is accumulating while this waits: stage 1 creates a sub-tenant and a configuration set per label with nothing reaping them, and the teardown lives in stage 2's Delete. If stage 1 lands first, that is an unbounded resource with no owner — worth either a reaping duty in stage 1 or an explicit note that stage 1 does not go near production until stage 2 exists.