Review: tile shows the DB size only; box disk is not tenant data Issue open
On branch feature/instance-db-stats-card
I reviewed d9bf4606, and Astra (via codex) reviewed it separately. Fixed in bb136250.
- P1: box disk % reached tenants.
box.Diskis how full the box's shared volume is, and every tenant on that box is in it.OwnerAppMetricsdocuments "unit-level rows only — no host totals". With that figure on the Overview, an owner could watch their neighbours' disk use. I removedDiskFracandDiskFracMax. Disk headroom is an operator alert (see #192), not tenant data. - P2: the new status read on every Overview had no deadline.
loadBoxJoinis one LIST plus a GET per box, and it ran onr.Context(). It now runs underinstanceStoreTimeout, so if the read is slow the tile shows an em-dash and the page still loads. - P3: the detail line didn't match the numbers. "from the copies responding" was wrong for a sum that counts sleeping copies, and "no recent data" showed beside a real disk %. Paul approved the new copy: "on disk, including copies that are asleep" and "no size reported yet". The tile is hidden for apps that run nothing.
- The commit added
.claude/settings.json, which would have installed ledger hooks in every checkout. Removed.
I added a render test that covers both tile states.