Flaky: TestExecBackendStartWorkerEnvWinsOverTenantFile fails under full-suite load Issue open
internal/activator's TestExecBackendStartWorkerEnvWinsOverTenantFile failed once in five go test ./... -count=1 runs on a branch that does not touch that package. Four other full-suite runs, two whole-package runs and five isolated -run repeats of the test all passed.
--- FAIL: TestExecBackendStartWorkerEnvWinsOverTenantFile (0.00s)
activator_test.go:4674: CARLOS_SIDECAR_TOKEN = "", want "agent-issued" — the agent-issued token must win over the tenant's own env fileTwo things point at a test-side race rather than a product bug:
- 0.00s. The assertion fires immediately, so the env map the spawn path composed was read before whatever writes
CARLOS_SIDECAR_TOKENhad landed, rather than after a timeout. - Load-dependent. It only reproduced with every package's tests running alongside it; the package on its own passed twice, at ~57s each.
The value it asserts on is the agent-issued sidecar token winning over a tenant-supplied env file — a precedence property worth keeping green, which is why the flake is worth fixing rather than retrying: the one shape this test would catch for real (the tenant's file winning) looks identical to the flake from the failure line alone.
Not investigated further — I was on unrelated work (per-environment object storage, #159) and stopped at establishing that the red was not mine. Filing so the next person to see it has the evidence rather than a fresh bisect.
Seen on per-instance-store at 062ee7f3, Go 1.26.5, 8-core Linux box.